[AI Generated] BugFix: check OpenVMM virtualization support - #4537
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the OpenVMM upstream vmm_tests preflight checks by detecting whether hardware virtualization is enabled before concluding that /dev/kvm and /dev/mshv backends are unavailable, so that hosts without virtualization enabled return a more accurate skip reason.
Changes:
- Add an
Lscpu.is_virtualization_enabled()guard in_ensure_vmm_tests_supported()to detect missing VT-x/AMD-V (or equivalent) earlier. - Update and extend selftests to mock
Lscpuand to assert the virtualization guard is evaluated before probing device paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| selftests/test_openvmm_tests_suite.py | Extends unit coverage by mocking Lscpu and adding a guard-ordering test. |
| lisa/microsoft/testsuites/openvmm/openvmm_tests.py | Adds virtualization-enabled detection to improve skip reason accuracy when /dev/kvm and /dev/mshv are absent. |
✅ AI Test Selection — PASSED3 test case(s) selected (view run) Marketplace image: microsoftcblmariner azure-linux-3 azure-linux-3 latest
Test case details
|
|
@copilot resolve conflict |
Resolved. The only conflict was in the |
✅ AI Test Selection — PASSED3 test case(s) selected (view run) Marketplace image: microsoftcblmariner azure-linux-3 azure-linux-3 latest
Test case details
|
Summary
Checks OpenVMM host hardware virtualization support before deciding whether
/dev/kvmor/dev/mshvbackends are available, so hosts without virtualization enabled report the correct skip reason.Validation Results