kernel_installer transformer: Use main repo component as default - #4547
Conversation
- Use main as repo component as default enabling custom ppa kernel installation. - Pipe through `cat` so apt's stdout is not a TTY.
🤖 AI Test SelectionNo test cases were selected for this PR. |
🤖 AI Test SelectionNo test cases were selected for this PR. |
SRIKKANTH
changed the title
There was a problem hiding this comment.
⚠️ Not ready to approve
The proposed-repo selection logic appears to regress the default is_proposed=True path for the Ubuntu archive, and the new apt search | cat pipeline can mask apt failures without pipefail.
Key Test Cases:
smoke_test|verify_reboot_in_platform
Impacted LISA Features:
StartStop
Tested Azure Marketplace Images:
- canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
- canonical ubuntu-24_04-lts server latest
Pull request overview
This PR updates the Ubuntu repo-based kernel installer to (1) default the APT repo component to main for more repository types and (2) prevent apt search from hanging due to pager behavior when stdout is treated as a TTY.
Changes:
- Adjust repo-entry construction to default to
mainin additionalis_proposedscenarios. - Pipe
apt searchoutput throughcat(and redirect stderr) to avoid interactive pager hangs.
File summaries
| File | Description |
|---|---|
| lisa/transformers/kernel_installer.py | Updates repository entry selection logic and changes the apt search invocation used for extracting the installed kernel version. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
🤖 AI Test SelectionNo test cases were selected for this PR. |
There was a problem hiding this comment.
⚠️ Not ready to approve
The proposed-repo fallback logic appears to change the default repo installer behavior for is_proposed=True in a way that may prevent proposed kernels from being used, and the new apt search invocation is brittle.
Key Test Cases:
smoke_test|verify_reboot_in_platform
Impacted LISA Features:
StartStop
Tested Azure Marketplace Images:
- canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
catso apt's stdout is not a TTY.Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results