fix(libvirt): give cloud-hypervisor source build a dedicated timeout - #4590
Merged
Conversation
CloudHypervisorSourceInstaller ran `cargo build --release` with LISA's default 600-second command timeout. A cold, from-scratch release build compiles vendored native crates -- openssl-src (which builds OpenSSL from C source), zstd-sys and libssh2-sys -- that can exceed 600s on a slow bare-metal agent or a cold cache. Observed in build 20260708.1 (BareMetal L1VH Test), job "GUEST Stress TESTS - Shard 2": the build was killed at 600.223s while only 140/243 crates in, raising "AssertionError: Failed to build cloud-hypervisor" and failing the job before any test ran. Add CLOUD_HYPERVISOR_BUILD_TIMEOUT_SECONDS = 1800 (mirroring RUSTUP_INSTALL_TIMEOUT_SECONDS) and pass it to the build execute so a legitimately-long build is not killed prematurely.
🤖 AI Test SelectionNo test cases were selected for this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces CI flakiness in the libvirt SUT orchestrator by preventing cloud-hypervisor source builds from being killed by LISA’s default 600-second command timeout during cold-cache, from-scratch cargo build --release runs.
Changes:
- Add a dedicated
CLOUD_HYPERVISOR_BUILD_TIMEOUT_SECONDS = 1800constant alongside the existing Rustup timeout constant. - Pass the new timeout to the
cargo build --releaseinvocation inCloudHypervisorSourceInstaller._build_and_install().
LiliDeng
approved these changes
Jul 10, 2026
anirudhrb
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudHypervisorSourceInstaller ran
cargo build --releasewith LISA's default 600-second command timeout. A cold, from-scratch release build compiles vendored native crates -- openssl-src (which builds OpenSSL from C source), zstd-sys and libssh2-sys -- that can exceed 600s on a slow bare-metal agent or a cold cache.Observed in job the build was killed at 600.223s while only 140/243 crates in, raising "AssertionError: Failed to build cloud-hypervisor" and failing the job before any test ran.
Add CLOUD_HYPERVISOR_BUILD_TIMEOUT_SECONDS = 1800 (mirroring RUSTUP_INSTALL_TIMEOUT_SECONDS) and pass it to the build execute so a legitimately-long build is not killed prematurely.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results