lvbs_prod_boot: fix VSM regex to handle SSH line endings - #4614
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LvbsProdBoot LVBS production boot validation to make the dmesg check for VSM “VTL1 boot thread” messages more tolerant of SSH line ending variations.
Changes:
- Simplified the VSM dmesg regex to avoid strict end-of-line matching (intended to tolerate
\r\n). - Updated the example comment for the expected VSM message.
praveen-pk
force-pushed
the
lvbs-prod-test
branch
from
July 27, 2026 18:17
a417bc2 to
bb1b4b0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
lisa/microsoft/testsuites/lvbs/lvbs_prod_boot.py:83
- Using
\s+in the VSM regex can match across newlines (since\sincludes\n), and dropping line anchoring makes the check less precise. It’s safer to keep the match line-based and still handle CRLF by allowing an optional\rbefore end-of-line.
dmesg_output = dmesg.get_output(force_run=True)
vsm_pattern = re.compile(r"vsm:\s+cpu\d+\s+entering vtl1 boot thread")
vsm_matches = vsm_pattern.findall(dmesg_output)
Simply the regex and ignore the line endings. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
praveen-pk
force-pushed
the
lvbs-prod-test
branch
from
July 27, 2026 18:26
bb1b4b0 to
0e035c2
Compare
praveen-pk
commented
Jul 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
lisa/microsoft/testsuites/lvbs/lvbs_prod_boot.py:45
- Minor: The example is hard-coded to
cpu1, but the regex matches anycpu\d+. Using a generic example avoids implying the test expects a specific CPU index.
Example matched string: "vsm: cpu1 entering vtl1 boot thread"
lisa/microsoft/testsuites/lvbs/lvbs_prod_boot.py:79
- Minor: This comment example is hard-coded to
cpu1, but the check accepts anycpu\d+. Consider making the example generic to reduce confusion when triaging failures.
# Example: "vsm: cpu1 entering vtl1 boot thread"
lisa/microsoft/testsuites/lvbs/lvbs_prod_boot.py:88
- Minor: The failure message implies the expected log is specifically for
cpu1, but the regex accepts any CPU index. Also consider adding a concrete investigation hint (e.g., grepping dmesg forvsm) to make the exception more actionable.
raise LisaException(
"No VSM VTL1 boot thread messages found in dmesg. "
"Expected messages like 'vsm: cpu1 entering vtl1 boot thread'. "
"The VSM module may not be active in this image."
LiliDeng
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simply the regex and ignore the line endings.
Related PR
#4584
Type of Change
Checklist
Test Validation
Key Test Cases:
Tested Azure Marketplace Images:
Images are not public. So, not posting here.
Test Results
VM Size:
Standard_E16as_v5