Nic: allow bind and unbind by device uuid and sysfs path - #4655
Open
mcgov (mcgov) wants to merge 1 commit into
Open
Nic: allow bind and unbind by device uuid and sysfs path#4655mcgov (mcgov) wants to merge 1 commit into
mcgov (mcgov) wants to merge 1 commit into
Conversation
Nics.bind and Nics.unbind required a NicInfo, so devices that are not represented in the node's nic list (for example a VF that has just been hot removed) could not be rebound. Accept either a NicInfo or a raw device uuid string plus the driver sysfs path. Also skip nics without an assigned ip address in get_nic_by_subnet, which previously raised while parsing an empty address. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d5f58ad-b9df-4420-ad37-22caee78e925
mcgov (mcgov)
requested review from
LiliDeng and
Johnson (johnsongeorge-w)
as code owners
August 12, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 9 of a stacked series that reworks the DPDK SRIOV hot plug tests. Stacked on #4654, review only the last commit.
Nics.bindandNics.unbindrequired aNicInfo, so a device that is not represented in the node's nic list (for example a VF that has just been hot removed) could not be rebound. They now accept either aNicInfoor a raw device uuid string plus the driver sysfs path.get_nic_by_subnetskips nics without an assigned ip address instead of raising while parsing an empty address.Key Test Cases:
verify_dpdk_sriov_rescind_failover_send_only|verify_dpdk_build_netvsc|verify_dpdk_build_failsafe
Impacted LISA Features:
Sriov, NetworkInterface
Tested Azure Marketplace Images:
canonical 0001-com-ubuntu-server-jammy 22_04-lts latestredhat rhel 9_5 latest