Reduce locking contention over fd iterations - #1111
Open
Jay Bosamiya (Microsoft) (jaybosamiya-ms) wants to merge 1 commit into
Open
Reduce locking contention over fd iterations#1111Jay Bosamiya (Microsoft) (jaybosamiya-ms) wants to merge 1 commit into
Jay Bosamiya (Microsoft) (jaybosamiya-ms) wants to merge 1 commit into
Conversation
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
marked this pull request as ready for review
July 31, 2026 04:03
Member
Author
|
quick note: this change is independent of other changes in the stack, but I'm placing it here since it makes maintaining the stack on my end easier rather than maintaining a mega-merge. fingers crossed the new github stacked PRs support (finally in public preview today!) will soon support merge queues + squash merges well, and we'll be able to use them; would make things a significantly easier to manage in our project |
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/fix-directory-permissions
branch
from
July 31, 2026 21:49
a9bb991 to
4326f3b
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/reduced-locking-on-iter
branch
from
July 31, 2026 21:49
31ee930 to
3e69d02
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
requested a review
from Weidong Cui (wdcui)
August 3, 2026 16:45
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/fix-directory-permissions
branch
from
August 4, 2026 00:08
4326f3b to
c39dab9
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/reduced-locking-on-iter
branch
from
August 4, 2026 00:19
3e69d02 to
c538da9
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
changed the base branch from
jayb/fix-directory-permissions
to
main
August 4, 2026 00:20
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By storing a tiny bit of data, we don't need to bother grabbing a lock before we know which subsystem an FD belongs to when iterating, and can selectively only grab locks when pointing at the correct subsystem.