Name resource fc108 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automation cookbook. Instances of name are also all changed to machine_name.
|
|
jazaval
approved these changes
Dec 13, 2017
Contributor
jazaval
left a comment
jazaval
left a comment
There was a problem hiding this comment.
Foodcritic and machine_name smoke tests pass - looks good!
americanhanko
approved these changes
Dec 13, 2017
Collaborator
americanhanko
left a comment
americanhanko
left a comment
There was a problem hiding this comment.
Looks great. Thanks, @mjmerin
brownmike
approved these changes
Dec 13, 2017
ehanlon
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 2042302 - FC108: Resource should not define a property named 'name': ./resources/name.rb:7