Release plist and macos_user resources, new Xcode libraries, test cookbook and documentation. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correctly include modules - Correctly setup spec_helper - Correct unit test / respec setup
- Boolean values are working - Array and data type values are not - PlistBuddy "commands" (add, print, etc.) are passing
- Skip Array and Dict types as their implementation will be more complicated - Add test for float type - Put the correct type in the test description - Cookstyle changes
- Add separate test cookbook for PlistBuddy resource - Add kitchen.yml for the above purpose - Modify and update plistbuddy resource/helpers
- Opportunistic cleanup of xcode test - some temp debugging info in resource definition - Rename name_property to command so as to not override action
- Removed 'bool' prefix from boolean types, as that was somehow causing issues - Changed name_property to the path and removed that property - Use actual actions in the resource for the PlistBuddy commands
- Not sure how the previous test was passing previously, but I adjusted the boolean value for the BazEntry test so that the signature input matches the output
- The data type should only be used when adding a value to a plist. Otherwise, we don't need to use the data type
Add PlistBuddy Resource
* first commit add_user recipe * Testing Refactor & macos_user resource - Create new testing cookbook that contains tests for both plistbuddy and macos_user resources. The hope here is to have a single testing cookbook that contains multiple suites and suite testing variations - Create new macos_user resource - contains single boolean 'true' settings for autologin and admin user. Still work to be done for admin user and all steps that need to be taken to acheive the task. * fix method call * fix another method call * user native ruby File class and not overriden * fix some minor issues with resource; add kcpassword file * Add OG Ruby kcpassword file helper module * slightly different approach for Kcpassword module * passing test * Fix up kcpassword library module, smoke tests - Modify Kcpassword helper module to use a method for magic bits. This isn't ideal, but it works for now - Update smoke tests so that john_jr's group ID is 20. This may not be correct, but setting as 20 until it is further investigated * opportunistic refactor of keep_awake recipe * Refactor testing cookbook layout - Consolodate testing suites into single default suite - Add tests for keep_awake recipe - Use more common examples to test PlistBuddy resource * move xcode test to test cookbook * Opportunistic bug fix for plistbuddy resource - Previously, the plistbuddy resource did not allow any keys with spaces unless they were used in the value itself. Now, you can use keys with spaces in the value property without needing to double-quote it - Also, fix the PlistBuddy executable string to be correct * revert kcpassword.rb helper to a671164 * fix incorrect PlistBuddy data type name * Fix kcpassword.rb and update plistbuddy UTs * Extract disabling screen saver to plistbuddy - Also, skip Xcode test temporarily * PlistBuddy idempotence - Remove systemsetup and pmset resource calls in keep_awake until they are made idempotent * update test and plist name * Implement binary plist conversion - Changes to binary plists via PlistBuddy must be converted back to binary since the change implicitly converts the file to xml. This change contains logic to convert back to binary if the file is detected to be binary in the first place. * attempts at idempotence using chef helper methods * early commit to get it on the remote * implement logic for plist return type to ruby data type * Add floating type value support A wild FAILING TEST appeared! ... HANKO used TDD! It's super effective! * move function * real idempotence! * passing all unit tests * update test cookbook name * update new_users integration tests * systemsetup idempotence * all smoke and unit tests passing * quick fix for timezone bug * remove kcpassword file as it is no longer needed * update path for test cookbook to be default repo name * Rename keep_awake_spec.rb to keep_awake_test.rb * Rename preferences_spec.rb to preferences_test.rb * Rename new_users_spec.rb to new_users_test.rb * fix typo * Use relative path for macos cookbook source * Improve readability of relative path for macos cookbook source * Bump version * Addressing changes in Pull Request #14 - Fix bug where screensaver was not properly being disabled, update tests accordingly - Rename plistbuddy resource to plist, including all related files and callers - Rename kcpassword helper to macos_user to match helper -> resource convention; fix top level namespace to be MacOS - Correctly name recipe unit tests - Implement plist resource into disable_software_updates.rb recipe - Add disable_software_updates.rb recipe to default kitchen suite and appropriate smoke tests - Remove relatively useless logic in systemsetup value property coercion * Implement binary plist conversion * Fix unit test and apply the Law of Demeter
Hotfix/simulators not found
automation cookbook. Instances of name are also all changed to machine_name.
Fix failing disable software updates smoke tests on 10.11
Name resource fc108
this occurs when integrated with the macos-user test recipe
add sleep for El Capitan platform to avoid race condition
* implement build definition badge and minor tweaks * Add descriptions and attribute lists for recipes * Remove 'description' label from recipe names * Bump version, add documentation dir * Fix up the last commit * Separate 10.12 and 10.13 build status * Add table for build status * Add plist resource documentation * Add Xcode documentation
americanhanko
approved these changes
Dec 14, 2017
Collaborator
There was a problem hiding this comment.
There's a couple of bugs that need to be resolved with 10.13.2, but I think we're finally ready to get these changes into master. Additionally, this merge contains a breaking API change for the name resource as it was changed to machine_name to adhere to FC109
Edit: version bumped, disregard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging PRs #14, #16, #17, #18, #19, #21, #22, #23 into master.