fix(pptx): ignore empty llm captions - #1886
Merged
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Whitespace-only captions must preserve the shape-name fallback, and the regression assertion should verify the intended output.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Prevents PPTX conversion failures when LLM image captioning returns None.
Changes:
- Filters missing LLM captions when composing image alt text.
- Adds regression coverage for
Nonecaptions.
File summaries
| File | Description |
|---|---|
packages/markitdown/tests/test_module_misc.py |
Adds regression coverage, but the assertion does not verify preservation of embedded alt text and uses the deprecated result alias. |
packages/markitdown/src/markitdown/converters/_pptx_converter.py |
Handles None captions, but whitespace-only captions can bypass the shape-name fallback. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoneFixes #1534
Tests