Fix omml template bugs. - #2257
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fallback handling for unrecognized OMML attribute values
get_val()returned the lookup key itself when an OMML attribute value was notfound in its mapping table. Callers use that result as a
str.format()template,so an unrecognized value produced malformed LaTeX or raised (
ValueError,IndexError,KeyError) rather than falling back to a sensible default. Becausepre_process_docxcatches exceptions per part, a single unrecognized valuesilently disabled equation conversion for an entire
document.xml.get_val()now falls back to the caller'sdefaulton a miss, so only templatesdefined in
latex_dict.pyreach.format(). The two call sites that legitimatelypass a character through as literal text (
do_ddelimiters,do_naryoperators)now use a new
get_char()helper that retains the previous behavior.do_groupchr()passed no default at all; addedCHR_DEFAULT["GROUP_CHR_VAL"](
\underbrace, matching ECMA-376's U+23DF default for the grouping character).This also fixes an
AttributeErrorwhen<m:groupChr>has no<m:chr>child.Affected handlers:
do_acc,do_bar,do_f,do_groupchr. Recognized values areunchanged. Existing tests pass, including
test_docx_equations.