Skip to content

Fixed snapshot lookup to use exact match#2165

Merged
xiangyan99 merged 1 commit intomainfrom
snapshot_exact_id
Mar 23, 2026
Merged

Fixed snapshot lookup to use exact match#2165
xiangyan99 merged 1 commit intomainfrom
snapshot_exact_id

Conversation

@xiangyan99
Copy link
Copy Markdown
Member

What does this PR do?

[Provide a clear, concise description of the changes]

Fixed snapshot lookup to use exact match

[Add additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Azure File Shares snapshot lookup behavior to avoid ambiguous substring matching when locating snapshots by resource ID.

Changes:

  • Updated snapshot lookup logic to require an exact (case-insensitive) match on snapshot resource ID rather than using substring matching.
  • Added a server changelog entry documenting the bug fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/Azure.Mcp.Tools.FileShares/src/Services/FileSharesService.cs Changes snapshot selection logic to use exact resource ID match instead of Contains, preventing false-positive matches.
servers/Azure.Mcp.Server/changelog-entries/1774298605674.yaml Adds changelog entry for the snapshot lookup bug fix.

@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Mar 23, 2026
@xiangyan99 xiangyan99 merged commit 58a7245 into main Mar 23, 2026
31 checks passed
@xiangyan99 xiangyan99 deleted the snapshot_exact_id branch March 23, 2026 21:17
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Mar 23, 2026
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants