Fixed snapshot lookup to use exact match (#2165)#2168
Merged
xiangyan99 merged 1 commit intorelease/azure/2.xfrom Mar 23, 2026
Merged
Fixed snapshot lookup to use exact match (#2165)#2168xiangyan99 merged 1 commit intorelease/azure/2.xfrom
xiangyan99 merged 1 commit intorelease/azure/2.xfrom
Conversation
xiangyan99
requested review from
a team,
ankushbindlish2 and
kszobi
as code owners
xiangyan99
requested review from
JasonYeMSFT,
JonathanCrd,
chidozieononiwu,
fanyang-mono,
jongio and
wbreza
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes file share snapshot lookup to avoid accidental matches by switching from substring matching on the snapshot resource ID to an exact match, and adds a changelog entry documenting the bug fix.
Changes:
- Updated snapshot lookup logic to use exact, case-insensitive resource ID comparison (instead of
Contains). - Added an Azure MCP Server changelog entry under “Bugs Fixed” for the snapshot lookup behavior change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.FileShares/src/Services/FileSharesService.cs | Makes snapshot ID matching exact to prevent incorrect snapshot selection when IDs share substrings. |
| servers/Azure.Mcp.Server/changelog-entries/1774298605674.yaml | Documents the bug fix in the server changelog entry format. |
alzimmermsft
approved these changes
Mar 23, 2026
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes][Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline