Skip to content

Update HttpRequestException handling to check for StatusCode (#2172)#2200

Merged
alzimmermsft merged 1 commit intomicrosoft:release/azure/2.xfrom
alzimmermsft:UpdateHttpRequestExceptionHandling2x
Mar 25, 2026
Merged

Update HttpRequestException handling to check for StatusCode (#2172)#2200
alzimmermsft merged 1 commit intomicrosoft:release/azure/2.xfrom
alzimmermsft:UpdateHttpRequestExceptionHandling2x

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

What does this PR do?

PR #2172 porting to 2.x branch.

Updates handling of HttpRequestException to check for StatusCode being non-null and using it before falling back to default of HttpStatusCode.ServiceUnavailable. Also adds handling for HttpRequestException to BaseCommand.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

…ft#2172)

* Update HttpRequestException handling to check for StatusCode

* Add CHANGELOG entries
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports #2172 to the 2.x branch by improving HttpRequestException handling so returned status codes are more specific (when available), with changelog entries for both Azure and Fabric servers.

Changes:

  • Update GlobalCommand to prefer HttpRequestException.StatusCode (when non-null) over a default 503 ServiceUnavailable.
  • Add HttpRequestException status-code handling to BaseCommand for non-GlobalCommand derived commands.
  • Add changelog entry YAMLs for Azure and Fabric server packages.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
servers/Fabric.Mcp.Server/changelog-entries/1774379067978.yaml Adds Fabric server changelog note for improved HttpRequestException status reporting
servers/Azure.Mcp.Server/changelog-entries/1774379055021.yaml Adds Azure server changelog note for improved HttpRequestException status reporting
core/Microsoft.Mcp.Core/src/Commands/GlobalCommand.cs Uses httpEx.StatusCode ?? ServiceUnavailable when mapping exceptions to HTTP status codes
core/Microsoft.Mcp.Core/src/Commands/BaseCommand.cs Adds HttpRequestException to default status-code mapping for base command exception handling

Comment thread core/Microsoft.Mcp.Core/src/Commands/BaseCommand.cs
Comment thread core/Microsoft.Mcp.Core/src/Commands/GlobalCommand.cs
Comment thread core/Microsoft.Mcp.Core/src/Commands/GlobalCommand.cs
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Mar 25, 2026
@alzimmermsft alzimmermsft merged commit af6b57c into microsoft:release/azure/2.x Mar 25, 2026
29 checks passed
@alzimmermsft alzimmermsft deleted the UpdateHttpRequestExceptionHandling2x branch March 25, 2026 18:26
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants