Skip to content

Update HttpRequestException handling to check for StatusCode (#2172) #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 1 commit into from
Mar 25, 2026
+8 −1
Merged

Update HttpRequestException handling to check for StatusCode (#2172) #2200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/Microsoft.Mcp.Core/src/Commands/BaseCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ protected virtual void HandleException(CommandContext context, Exception ex)
{
ArgumentException => HttpStatusCode.BadRequest, // Bad Request for invalid arguments
InvalidOperationException => HttpStatusCode.UnprocessableEntity, // Unprocessable Entity for configuration errors
HttpRequestException httpEx => httpEx.StatusCode ?? HttpStatusCode.ServiceUnavailable,
_ => HttpStatusCode.InternalServerError // Internal Server Error for unexpected errors
};

Expand Down
2 changes: 1 addition & 1 deletion core/Microsoft.Mcp.Core/src/Commands/GlobalCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ protected override TOptions BindOptions(ParseResult parseResult)
KeyNotFoundException => HttpStatusCode.NotFound,
AuthenticationFailedException => HttpStatusCode.Unauthorized,
RequestFailedException rfEx => (HttpStatusCode)rfEx.Status,
HttpRequestException => HttpStatusCode.ServiceUnavailable,
HttpRequestException httpEx => httpEx.StatusCode ?? HttpStatusCode.ServiceUnavailable,
_ => HttpStatusCode.InternalServerError
Comment thread
alzimmermsft marked this conversation as resolved.
Comment thread
alzimmermsft marked this conversation as resolved.
};

Expand Down
3 changes: 3 additions & 0 deletions servers/Azure.Mcp.Server/changelog-entries/1774379055021.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changes:
- section: "Other Changes"
description: "Update HttpRequestException to attempt to return a more specific status code for better troubleshooting"
3 changes: 3 additions & 0 deletions servers/Fabric.Mcp.Server/changelog-entries/1774379067978.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changes:
- section: "Other Changes"
description: "Update HttpRequestException to attempt to return a more specific status code for better troubleshooting"
Loading