Skip to content

Fix incorrect SignalR caching #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 2 commits into from
Mar 26, 2026
Merged

Fix incorrect SignalR caching #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd23f81
Fix incorrect SignalR caching
alzimmermsft Mar 26, 2026
0333469
Move caching spot
alzimmermsft Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions servers/Azure.Mcp.Server/changelog-entries/1774535859275.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changes:
- section: "Bugs Fixed"
description: "Fix incorrect SignalR caching"
6 changes: 3 additions & 3 deletions tools/Azure.Mcp.Tools.SignalR/src/Services/SignalRService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ public async Task<IEnumerable<Runtime>> GetRuntimeAsync(
{
runtimes.Add(ConvertToRuntimeModel(runtime));
}

await _cacheService.SetAsync(CacheGroup, cacheKey, signalRName, s_cacheDuration, cancellationToken);
}
Comment thread
alzimmermsft marked this conversation as resolved.

await _cacheService.SetAsync(CacheGroup, cacheKey, runtimes, s_cacheDuration, cancellationToken);
}
else
{
Expand Down Expand Up @@ -106,7 +106,7 @@ public async Task<IEnumerable<Runtime>> GetRuntimeAsync(
}

runtimes.Add(ConvertToRuntimeModel(signalRResource.Value));
await _cacheService.SetAsync(CacheGroup, cacheKey, signalRName, s_cacheDuration, cancellationToken);
await _cacheService.SetAsync(CacheGroup, cacheKey, runtimes, s_cacheDuration, cancellationToken);
}

Comment thread
xiangyan99 marked this conversation as resolved.
return runtimes;
Expand Down