Fix incorrect SignalR caching#2221
Merged
alzimmermsft merged 2 commits intomicrosoft:mainfrom Mar 26, 2026
Merged
Conversation
alzimmermsft
requested review from
a team,
HaofanLiao and
JialinXin
as code owners
alzimmermsft
requested review from
KarishmaGhiya,
chidozieononiwu,
hallipr,
jairmyree,
jongio,
vukelich and
wbreza
g2vinay
approved these changes
Mar 26, 2026
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect caching behavior in the SignalR tool so runtime listings are cached (and can be returned from cache on subsequent calls).
Changes:
- Update
SignalRService.GetRuntimeAsyncto cache the collectedList<Runtime>instead of caching thesignalRNamestring. - Add an Azure.Mcp.Server changelog entry documenting the bug fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.SignalR/src/Services/SignalRService.cs | Fixes the cached value type to match what GetAsync<List<Runtime>> expects. |
| servers/Azure.Mcp.Server/changelog-entries/1774535859275.yaml | Adds a “Bugs Fixed” changelog entry for the SignalR caching fix. |
xiangyan99
reviewed
Mar 26, 2026
xiangyan99
approved these changes
Mar 26, 2026
alzimmermsft
added a commit
to alzimmermsft/mcp
that referenced
this pull request
Mar 27, 2026
* Fix incorrect SignalR caching * Move caching spot
alzimmermsft
added a commit
that referenced
this pull request
Mar 27, 2026
Fix incorrect SignalR caching (#2221) * Fix incorrect SignalR caching * Move caching spot
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Apr 20, 2026
* Fix incorrect SignalR caching * Move caching spot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix incorrect SignalR cache handling where the collected runtimes were never cached, and therefore the cache was being used incorrectly.
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline