Skip to content

Fix incorrect SignalR caching#2254

Merged
alzimmermsft merged 1 commit intomicrosoft:release/azure/2.xfrom
alzimmermsft:FixIncorrectSignalRCaching2.x
Mar 27, 2026
Merged

Fix incorrect SignalR caching#2254
alzimmermsft merged 1 commit intomicrosoft:release/azure/2.xfrom
alzimmermsft:FixIncorrectSignalRCaching2.x

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

What does this PR do?

Fix incorrect SignalR cache handling where the collected runtimes were never cached, and therefore the cache was being used incorrectly.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

* Fix incorrect SignalR caching

* Move caching spot
Copilot AI review requested due to automatic review settings March 27, 2026 19:59
@alzimmermsft alzimmermsft requested review from a team as code owners March 27, 2026 19:59
@alzimmermsft alzimmermsft requested review from JonathanCrd, KarishmaGhiya, chidozieononiwu, hallipr, jairmyree, tmeschter and vukelich and removed request for a team March 27, 2026 19:59
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server Mar 27, 2026
@github-actions github-actions Bot added the tools-SignalR Azure SignalR label Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes SignalR runtime caching so the actual collected runtime results are cached and subsequent requests can correctly return cached runtimes.

Changes:

  • Cache the collected List<Runtime> in SignalRService.GetRuntimeAsync instead of caching the SignalR name.
  • Add an Azure.Mcp.Server changelog entry documenting the bug fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tools/Azure.Mcp.Tools.SignalR/src/Services/SignalRService.cs Corrects cache SetAsync to store the runtime results that GetAsync<List<Runtime>> expects.
servers/Azure.Mcp.Server/changelog-entries/1774535859275.yaml Adds a “Bugs Fixed” changelog entry for the SignalR caching fix.

Comment thread tools/Azure.Mcp.Tools.SignalR/src/Services/SignalRService.cs
@alzimmermsft alzimmermsft enabled auto-merge (squash) March 27, 2026 20:16
@alzimmermsft alzimmermsft merged commit c4f08ed into microsoft:release/azure/2.x Mar 27, 2026
31 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server Mar 27, 2026
@alzimmermsft alzimmermsft deleted the FixIncorrectSignalRCaching2.x branch March 27, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools-SignalR Azure SignalR

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants