POCO-based options follow-ups - #3143
Merged
Alan Zimmer (alzimmermsft) merged 2 commits intoJul 23, 2026
Merged
Conversation
Alan Zimmer (alzimmermsft)
requested review from
a team,
Arun R (arunrab),
Jon Gallant (jongio),
Michael (micha31r) and
wchigit
as code owners
July 23, 2026 20:48
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up cleanup after the POCO-based options migration, primarily removing unused option constants/properties and correcting an option description to better match the current option surface.
Changes:
- Removed unused option names/properties across several toolsets (SreAgent, Insights, FoundryExtensions, Deploy, ACR).
- Sealed
IoTHubGetOptionsto prevent inheritance. - Corrected Azure Backup’s
Locationoption description constant usage and removed the now-unusedLocationNameconstant.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.SreAgent/src/Options/SreAgentOptionDefinitions.cs | Removes an unused option name constant. |
| tools/Azure.Mcp.Tools.IoTHub/src/Options/IoTHub/IoTHubGetOptions.cs | Marks the options type as sealed. |
| tools/Azure.Mcp.Tools.Insights/src/Options/InsightsGetOptions.cs | Removes unused AuthMethod option and related using. |
| tools/Azure.Mcp.Tools.FoundryExtensions/src/Options/Models/ResourceGetOptions.cs | Removes unused AuthMethod option and related using. |
| tools/Azure.Mcp.Tools.Deploy/src/Options/Plan/GetOptions.cs | Removes an unused WorkspaceFolder option (but leaves a now-misleading description on ProjectName). |
| tools/Azure.Mcp.Tools.AzureBackup/src/Options/Backup/BackupStatusOptions.cs | Updates Location option description constant reference. |
| tools/Azure.Mcp.Tools.AzureBackup/src/Options/AzureBackupOptionDefinitions.cs | Removes unused LocationName constant and standardizes on Location. |
| tools/Azure.Mcp.Tools.Acr/src/Options/Registry/RegistryListOptions.cs | Removes unused Registry option from list options (registry name belongs on repository-list). |
msalaman
approved these changes
Jul 23, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Few small follow-ups after the migration to POCO-based options to remove a few unused parameters that were missed and fixing a description on one parameter.
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline