Skip to content

POCO-based options follow-ups - #3143

Merged
Alan Zimmer (alzimmermsft) merged 2 commits into
microsoft:mainfrom
alzimmermsft:PostPocoMigrationFollowups
Jul 23, 2026
Merged

POCO-based options follow-ups#3143
Alan Zimmer (alzimmermsft) merged 2 commits into
microsoft:mainfrom
alzimmermsft:PostPocoMigrationFollowups

Conversation

@alzimmermsft

Copy link
Copy Markdown
Contributor

What does this PR do?

Few small follow-ups after the migration to POCO-based options to remove a few unused parameters that were missed and fixing a description on one parameter.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Follow-up cleanup after the POCO-based options migration, primarily removing unused option constants/properties and correcting an option description to better match the current option surface.

Changes:

  • Removed unused option names/properties across several toolsets (SreAgent, Insights, FoundryExtensions, Deploy, ACR).
  • Sealed IoTHubGetOptions to prevent inheritance.
  • Corrected Azure Backup’s Location option description constant usage and removed the now-unused LocationName constant.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.SreAgent/src/Options/SreAgentOptionDefinitions.cs Removes an unused option name constant.
tools/Azure.Mcp.Tools.IoTHub/src/Options/IoTHub/IoTHubGetOptions.cs Marks the options type as sealed.
tools/Azure.Mcp.Tools.Insights/src/Options/InsightsGetOptions.cs Removes unused AuthMethod option and related using.
tools/Azure.Mcp.Tools.FoundryExtensions/src/Options/Models/ResourceGetOptions.cs Removes unused AuthMethod option and related using.
tools/Azure.Mcp.Tools.Deploy/src/Options/Plan/GetOptions.cs Removes an unused WorkspaceFolder option (but leaves a now-misleading description on ProjectName).
tools/Azure.Mcp.Tools.AzureBackup/src/Options/Backup/BackupStatusOptions.cs Updates Location option description constant reference.
tools/Azure.Mcp.Tools.AzureBackup/src/Options/AzureBackupOptionDefinitions.cs Removes unused LocationName constant and standardizes on Location.
tools/Azure.Mcp.Tools.Acr/src/Options/Registry/RegistryListOptions.cs Removes unused Registry option from list options (registry name belongs on repository-list).

Comment thread tools/Azure.Mcp.Tools.Deploy/src/Options/Plan/GetOptions.cs Outdated
@alzimmermsft
Alan Zimmer (alzimmermsft) merged commit 50309cc into microsoft:main Jul 23, 2026
16 checks passed
@alzimmermsft
Alan Zimmer (alzimmermsft) deleted the PostPocoMigrationFollowups branch July 23, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants