Add azmcp sql db create and azmcp sql db delete commands and unit tests#434
Merged
ericshape merged 9 commits intomicrosoft:mainfrom Sep 17, 2025
Merged
Add azmcp sql db create and azmcp sql db delete commands and unit tests#434ericshape merged 9 commits intomicrosoft:mainfrom
azmcp sql db create and azmcp sql db delete commands and unit tests#434ericshape merged 9 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds SQL database create and delete functionality to the Azure MCP Server. The implementation includes comprehensive unit tests and live tests to ensure reliability of the new database management operations.
- Adds
azmcp sql db createcommand with configurable database parameters (SKU, collation, size, etc.) - Adds
azmcp sql db deletecommand with idempotent behavior - Includes comprehensive unit and live test coverage for both operations
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DatabaseCreateCommand.cs | New command implementation for creating SQL databases with configurable options |
| DatabaseDeleteCommand.cs | New command implementation for deleting SQL databases with idempotent behavior |
| DatabaseCreateOptions.cs | Options class for database creation parameters |
| DatabaseDeleteOptions.cs | Options class for database deletion (extends base options) |
| DatabaseCreateCommandTests.cs | Comprehensive unit tests for database creation scenarios |
| DatabaseDeleteCommandTests.cs | Comprehensive unit tests for database deletion scenarios |
| SqlService.cs | Service implementation for create and delete database operations |
| ISqlService.cs | Interface additions for new database operations |
| SqlOptionDefinitions.cs | New option definitions for database configuration parameters |
| SqlSetup.cs | Registration of new commands in the command hierarchy |
| SqlJsonContext.cs | JSON serialization context updates for new result types |
| SqlCommandTests.cs | Live tests for database operations |
| Documentation files | Updated documentation with new command descriptions and examples |
Comments suppressed due to low confidence (1)
tools/Azure.Mcp.Tools.Sql/src/Services/SqlService.cs:470
- This throw statement appears to be orphaned and doesn't belong to any catch block in the visible context. It should be removed or properly associated with exception handling logic.
throw;
This was
linked to
issues
Sep 15, 2025
16 tasks
jongio
requested changes
Sep 17, 2025
Member
Author
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xiangyan99
reviewed
Sep 17, 2025
jongio
approved these changes
Sep 17, 2025
xiangyan99
approved these changes
Sep 17, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
… tests (microsoft#434) * Add sql db create command * add ending spaces * add sql db delete commands * update docs and changelog * address comments and update option usage after revbase * address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
azmcp sql db createandazmcp sql db deletecommands and unit testsGitHub issue number?
#126 #239 #309
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline