Fix the null value assignment in GetValueOrDefault()#457
Merged
ericshape merged 5 commits intomicrosoft:mainfrom Sep 16, 2025
Merged
Fix the null value assignment in GetValueOrDefault()#457ericshape merged 5 commits intomicrosoft:mainfrom
ericshape merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the GetValueOrDefault() method where optional nullable values were incorrectly being assigned default values (0 for int/long, false for bool) instead of null when not explicitly provided by the user.
- Improves the
HasOptionResult()method to properly handle bool options as switches or with explicit values - Updates
GetValueOrDefault()to check if an option was explicitly provided before returning values - Adds comprehensive test coverage for the fixed behavior across different nullable types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CommandResultExtensions.cs | Enhanced option presence detection and fixed null value assignment logic |
| CommandResultExtensionsTests.cs | Added comprehensive test coverage for nullable options with explicit and missing values |
Member
Author
|
once the review is done, I will add fix description into Changelog md file. |
Contributor
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jongio
approved these changes
Sep 16, 2025
Member
Author
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jongio
approved these changes
Sep 16, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
* Fix the null value assignment in GetValueOrDefault * fix format issue * fix Missing --limit uses the default value of 10 from DefaultValueFactory * fix the failed empty string unit test case in storage unit test * address comments about nullable type and default value is null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the null value assignment in GetValueOrDefault()
context: #437 (comment)
this bug fix is blocking #434
GitHub issue number?
#437
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline