Trim any surrounding quotes that may have been included in subscription#605
Merged
ArthurMa1978 merged 5 commits intomainfrom Sep 30, 2025
Merged
Trim any surrounding quotes that may have been included in subscription#605ArthurMa1978 merged 5 commits intomainfrom
ArthurMa1978 merged 5 commits intomainfrom
Conversation
ArthurMa1978
requested review from
JasonYeMSFT,
JonathanCrd,
alzimmermsft,
conniey,
hallipr,
joshfree and
tmeschter
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where Kusto queries fail when subscription IDs are enclosed in quotes by implementing quote trimming in the subscription command parsing logic.
- Adds quote trimming logic to handle subscription IDs enclosed in single or double quotes
- Updates CHANGELOG.md to document the bug fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/Azure.Mcp.Core/src/Commands/Subscription/SubscriptionCommand.cs | Adds quote trimming logic to subscription value parsing |
| servers/Azure.Mcp.Server/CHANGELOG.md | Documents the bug fix for quoted subscription IDs |
alzimmermsft
approved these changes
Sep 29, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
prvavill
approved these changes
Sep 29, 2025
live1206
approved these changes
Sep 30, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #152.
GitHub issue number?
#152
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline