Skip to content

Trim any surrounding quotes that may have been included in subscription #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurMa1978 merged 5 commits into from
Sep 30, 2025
Merged

Trim any surrounding quotes that may have been included in subscription #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c681415
Trim any surrounding quotes that may have been included in subscription
ArthurMa1978 Sep 28, 2025
6443260
Merge branch 'main' into mgmt-trim
ArthurMa1978 Sep 28, 2025
523c181
update
ArthurMa1978 Sep 28, 2025
9d2c742
Merge branch 'main' into mgmt-trim
ArthurMa1978 Sep 30, 2025
431d9ff
Fix subscription value handling in BindOptions
ArthurMa1978 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/Azure.Mcp.Core/src/Commands/Subscription/SubscriptionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ protected override TOptions BindOptions(ParseResult parseResult)
{
var options = base.BindOptions(parseResult);
options.Subscription = CommandHelper.GetSubscription(parseResult);
if (!string.IsNullOrEmpty(options.Subscription))
{
// Trim any surrounding quotes that may have been included in the input
options.Subscription = options.Subscription.Trim('"', '\'');
}

return options;
}
Expand Down
2 changes: 1 addition & 1 deletion servers/Azure.Mcp.Server/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ The Azure MCP Server updates automatically by default whenever a new release com
### Bugs Fixed

- Fixed problem where help option (`--help`) was showing an error and enabling it across all commands and command groups. [[#583](https://github.com/microsoft/mcp/pull/583)]

- Fixed `azmcp_kusto_table_schema` to return table schema. [[#530](https://github.com/microsoft/mcp/issues/530)]
- Fixed Kusto query fails when the sub id in the input query is enclosed in double quotes. [[#152](https://github.com/microsoft/mcp/issues/152)]

### Other Changes

Expand Down