fix(logging): support stderr redirection on Darwin - #448
Merged
Nitin Jamadagni (NitinJamadagni) merged 1 commit intoAug 7, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65184d9f-5f8d-463e-a86f-247cfcc5761c
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Nitin Jamadagni (NitinJamadagni)
approved these changes
Aug 6, 2026
Nick Wood (nwoodmsft)
approved these changes
Aug 7, 2026
Blair Urish (blairurish)
approved these changes
Aug 7, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a Darwin implementation of
RedirectStdErrusingsyscall.Dup2.Why this is needed
loggingRedirect.gois compiled on macOS and callsRedirectStdErr, but that function was previously implemented only for Linux and Windows. Any Darwin build that importspkg/loggingtherefore fails with:undefined: RedirectStdErrThis issue affects Darwin consumers whenever
pkg/loggingenters their build graph. Adding the platform-specific implementation restores macOS compilation.Darwin supports
Dup2, rather than the Linux implementation’sDup3, so it requires a platform-specific implementation.Validation
go test ./pkg/logginggo test ./pkg/...pkg/loggingfordarwin/amd64pkg/loggingfordarwin/arm64