Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the EndpointConfig interface by consolidating InfiniBand-specific configuration options into a nested Ib struct and enables connection creation directly from an Endpoint object. Key changes include storing the full EndpointConfig in Endpoint::Impl instead of individual fields, improving transport validation logic, and updating Python bindings accordingly.
Key Changes
- Refactored
EndpointConfigto nest IB-specific parameters (maxCqSize,maxCqPollNum,maxSendWr,maxWrPerSend) into anEndpointConfig::Ibstruct - Modified
Endpoint::Implto storeconfig_instead of separatetransport_,device_, andmaxWriteQueueSize_fields - Added
Communicator::connect()overload acceptingconst Endpoint&as the primary method, withEndpointConfigoverload as a wrapper
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
include/mscclpp/core.hpp |
Refactored EndpointConfig to nest IB options in Ib struct; added Endpoint::config() method; updated Communicator::connect() signature |
src/include/endpoint.hpp |
Changed Endpoint::Impl to store config_ instead of individual transport/device fields |
src/endpoint.cc |
Updated constructor and methods to use config_ member; added deserialization validation |
src/context.cc |
Improved transport validation with unified error message for mismatched transports |
src/connection.cc |
Removed redundant default maxWriteQueueSize initialization |
src/communicator.cc |
Refactored connect() to accept Endpoint directly; removed unnecessary std::move() calls |
src/include/communicator.hpp |
Removed unnecessary std::move() from future initialization |
python/mscclpp/core_py.cpp |
Updated Python bindings to expose nested Ib struct and modified connect() signatures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merged
chhwang
added a commit
that referenced
this pull request
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect()by anEndpoint, not only byEndpointConfig