Merged
Conversation
Contributor
Author
|
/azp run mscclpp-test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run mscclpp-test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #651 by resolving Python binding ambiguity and standardizing parameter naming conventions. The changes temporarily remove Communicator::connect(const Endpoint&, ...) to eliminate confusion with Communicator::connect(const EndpointConfig&, ...), and update parameter names across multiple Python binding files to follow snake_case convention.
Key changes:
- Removed ambiguous
Communicator::connectoverload withEndpointparameter - Standardized all Python binding parameter names from camelCase to snake_case
- Added
config()method binding to theEndpointclass
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| python/mscclpp/port_channel_py.cpp | Updated parameter names to snake_case for ProxyService, BasePortChannel, and PortChannel bindings |
| python/mscclpp/nvls_py.cpp | Converted parameter names to snake_case in SwitchChannel::DeviceHandle, NvlsConnection, and connect_nvls_collective |
| python/mscclpp/gpu_utils_py.cpp | Changed dataType parameter to data_type in toDlpack binding |
| python/mscclpp/executor_py.cpp | Reformatted execute method parameters to snake_case across multiple lines |
| python/mscclpp/core_py.cpp | Removed ambiguous Endpoint-based connect overloads, standardized parameter names, added Endpoint::config binding, and fixed lambda capture from Communicator to Context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
/azp run mscclpp-test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Binyang2014
approved these changes
Oct 24, 2025
Binyang2014
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Communicator::connect(const Endpoint&, ...)fromCommunicator::connect(const EndpointConfig&, ...). Temporarily removed the former one.