Skip to content

fixed regex in client info tests#448

Closed
Hadis-Fard wants to merge 3 commits into
microsoft:devfrom
Hadis-Fard:dev
Closed

fixed regex in client info tests#448
Hadis-Fard wants to merge 3 commits into
microsoft:devfrom
Hadis-Fard:dev

Conversation

@Hadis-Fard

Copy link
Copy Markdown

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 75.337% when pulling 3ccdd1c on Hadis-Fard:dev into 219de93 on Microsoft:dev.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 75.337% when pulling 72de60b on Hadis-Fard:dev into 219de93 on Microsoft:dev.

@Hadis-Fard
Hadis-Fard requested a review from ulvii June 20, 2017 20:19
\[DriverODBCVer\] => [0-9]{1,2}\.[0-9]{1,2}
\[DriverVer\] => [0-9]{1,2}\.[0-9]{1,2}\.[0-9]{4}
\[ExtensionVer\] => [0-9]\.[0-9]\.[0-9](\-((rc)|(preview))(\.[0-9]+)?)?(\+[0-9]+)?
\[ExtensionVer\] => [0-9]\.[0-9]\.[0-9](\-((RC[1-9]?)|(preview[1-9]?))(\.[0-9]+)?)?(\+[0-9]+)?

@ulvii ulvii Jun 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will match : 4.3.1randomtext

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-19.9%) to 55.467% when pulling 931b459 on Hadis-Fard:dev into 219de93 on Microsoft:dev.

@Hadis-Fard

Copy link
Copy Markdown
Author

Closing this due the duplicate PR #449

@Hadis-Fard Hadis-Fard closed this Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants