Disable all compiler optimization in sanitizer builds, too.

[Michael Friesen (mtfriesen)]

Description

Describe the purpose of and changes within this Pull Request.

We already turned off compiler optimizations in debug builds, but we left behind -Og (roughly equal to -O1) in sanitizer builds, partly because the compiler optimizations were masking bugs. Try to get a CI to pass with -O0, which disables all optimizations, to make it easier to debug.

Testing

Do any existing tests cover this change? Are new tests needed?

CI.

Documentation

Is there any documentation impact for this change?

No.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.30%. Comparing base (da06e4d) to head (411a16e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5409      +/-   ##
==========================================
+ Coverage   86.08%   86.30%   +0.22%     
==========================================
  Files          59       59              
  Lines       18328    18328              
==========================================
+ Hits        15777    15818      +41     
+ Misses       2551     2510      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Jack He (ProjectsByJackHe)]

Can you add in the PR description the implications of the compiler parameters?

i.e. what does -Og do vs -O0

[Michael Friesen (mtfriesen)]

Can you add in the PR description the implications of the compiler parameters?

i.e. what does -Og do vs -O0

Sure, I added a link to clang docs and summarized these two.

[Guillaume Hetier (guhetier)]

Test failure similar to #5355