Add logging for spinquic tests. - #5643
Conversation
| type: choice | ||
| options: | ||
| - "None" | ||
| - SpinQuic.Light |
There was a problem hiding this comment.
Wouldn't this one make more sense as a default?
Or if it isn't enough (look like it might contain very little), maybe we should consider adding what makes sense to it - no point in having a SpinQuic profile that is not enough to diagnose issues.
There was a problem hiding this comment.
Yeah, we'll see what these look like in the next few iterations.
There was a problem hiding this comment.
Sounds good. If it doesn't appear useful, I would not hesitate to delete the profile from the wprpr file and replace it by less specific one.
Guillaume Hetier (guhetier)
left a comment
Guillaume Hetier (guhetier)
left a comment
There was a problem hiding this comment.
Seems good to me in concept.
Most of the time though, spin test matter only when they trigger a crash. Shouldn't we focus on dump collection?
If the script does what it's supposed to do, having log-profile set to non-NULL should automatically coalesce all additional logs created into the artifacts folder. Today, the artifacts folder does not contain any ETL. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5643 +/- ##
==========================================
- Coverage 86.34% 85.75% -0.59%
==========================================
Files 60 60
Lines 18663 18663
==========================================
- Hits 16114 16004 -110
- Misses 2549 2659 +110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also, if what you mean by "dump collection" is a crash dump, the spinquic tool does not produce any crash dumps in user mode. |
## Description The Spin powershell script had support for gathering MsQuic logs but the CI is never using it. Let's add an option to configure logging in spin tests. For workflow dispatch, the user can control the log profile. For pull request and merge events, Basic.Light is used. ## Testing CI ## Documentation N/A
2 participants
Description
The Spin powershell script had support for gathering MsQuic logs but the CI is never using it.
Let's add an option to configure logging in spin tests. For workflow dispatch, the user can control the log profile. For pull request and merge events, Basic.Light is used.
Testing
CI
Documentation
N/A