[CP] Fix uint32 overflow in receive buffer growth (#6226) - #6246
Merged
Gaurav Singh (gaurav2699) merged 1 commit intoAug 24, 2026
Merged
Conversation
Guillaume Hetier (guhetier)
previously approved these changes
Aug 21, 2026
Collaborator
|
Please re-generate CLOG |
## Description Cap internally-managed stream receive buffers at 0x80000000 during auto-tuning and compute buffer growth in 64-bit, rejecting sizes above UINT32_MAX. This prevents a uint32 wrap that could spin the growth loop forever when a very large ConnFlowControlWindow is configured. App-owned mode behavior is unchanged. Fixes https://dev.azure.com/microsoft/OS/_workitems/edit/62826267/ ## Testing Added RecvBufferGrowthTest.WriteGrowthOverflow to cover the overflow boundary. Existing recv buffer tests pass. ## Documentation NA
Gaurav Singh (gaurav2699)
force-pushed
the
gaurasingh/cp_recv_buffer_overflow_2_5_copilot
branch
from
August 21, 2026 18:56
526ae73 to
2522a8b
Compare
Guillaume Hetier (guhetier)
approved these changes
Aug 21, 2026
Gaurav Singh (gaurav2699)
added a commit
that referenced
this pull request
Aug 24, 2026
## Description Cap internally-managed stream receive buffers at 0x80000000 during auto-tuning and compute buffer growth in 64-bit, rejecting sizes above UINT32_MAX. This prevents a uint32 wrap that could spin the growth loop forever when a very large ConnFlowControlWindow is configured. App-owned mode behavior is unchanged. Fixes https://dev.azure.com/microsoft/OS/_workitems/edit/62826267/ ## Testing Added RecvBufferGrowthTest.WriteGrowthOverflow to cover the overflow boundary. Existing recv buffer tests pass. ## Documentation NA <!-- Companion PR for release/2.5: #6246 -->
Gaurav Singh (gaurav2699)
merged commit Aug 24, 2026
367ac6b
into
release/2.5
282 of 283 checks passed
Gaurav Singh (gaurav2699)
deleted the
gaurasingh/cp_recv_buffer_overflow_2_5_copilot
branch
August 24, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cap internally-managed stream receive buffers at 0x80000000 during
auto-tuning and compute buffer growth in 64-bit, rejecting sizes above
UINT32_MAX. This prevents a uint32 wrap that could spin the growth loop
forever when a very large ConnFlowControlWindow is configured. App-owned
mode behavior is unchanged.
Fixes https://dev.azure.com/microsoft/OS/_workitems/edit/62826267/
Testing
Added RecvBufferGrowthTest.WriteGrowthOverflow to cover the overflow
boundary. Existing recv buffer tests pass.
Documentation
NA