Skip to content

Conversation

@gargsaumya
Copy link
Contributor

This pull request updates the CMakeLists.txt file in the mssql_python/pybind directory to include a new source file and necessary include directories for building the ddbc_bindings module.

Build system updates:

  • mssql_python/pybind/CMakeLists.txt: Added connection/connection.cpp to the ddbc_bindings module sources and included the root and connection directories in the target_include_directories to ensure proper header file resolution.

Checklist

  • Tests Passed (if applicable) : Verified building ddbc_bindings.cpp and connection.cpp using build.bat

Copilot AI review requested due to automatic review settings May 20, 2025 14:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the build configuration to include a new source file and additional include directories for building the ddbc_bindings module.

  • Updated the add_library command to incorporate "connection/connection.cpp".
  • Added the target_include_directories block to include the root and connection directories.

@gargsaumya gargsaumya changed the title FEAT: add library and include directories FEAT: update CMakeLists.txt to add new source file and include directories May 20, 2025
@gargsaumya
Copy link
Contributor Author

gargsaumya commented May 20, 2025

The removed function will be added in pooling PR.

@gargsaumya gargsaumya force-pushed the saumya/build-connc++ branch from f4e5384 to a0b11b6 Compare May 21, 2025 07:59
@sumitmsft sumitmsft merged commit fbc31a4 into main May 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants