Skip to content

FEAT: update CMakeLists.txt to add new source file and include directories #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sumitmsft merged 2 commits into from
May 21, 2025
Merged

FEAT: update CMakeLists.txt to add new source file and include directories #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0b11b6
add library and include directories
May 20, 2025
e798d98
removing this function, and will add it in pooling PR
May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion mssql_python/pybind/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,13 @@ execute_process(
)

# Add module library
add_library(ddbc_bindings MODULE ddbc_bindings.cpp)
add_library(ddbc_bindings MODULE ddbc_bindings.cpp connection/connection.cpp)

# Add include directories for your project
target_include_directories(ddbc_bindings PRIVATE
${CMAKE_CURRENT_SOURCE_DIR} # Root directory (for ddbc_bindings.h)
${CMAKE_CURRENT_SOURCE_DIR}/connection # connection directory (for connection.h)
)

# Set the output name to include Python version and architecture
set_target_properties(ddbc_bindings PROPERTIES
Expand Down
4 changes: 0 additions & 4 deletions mssql_python/pybind/connection/connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ SQLRETURN Connection::rollback() {
// to be added
}

SQLRETURN Connection::end_transaction(SQLSMALLINT completion_type) {
// to be added
}

SQLRETURN Connection::set_autocommit(bool enable) {
LOG("Setting autocommit mode");
// to be added
Expand Down
3 changes: 0 additions & 3 deletions mssql_python/pybind/connection/connection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ class Connection {
// Rollback the current transaction.
SQLRETURN rollback();

// End the transaction with the specified completion type.
SQLRETURN end_transaction(SQLSMALLINT completion_type);

// Enable or disable autocommit mode.
SQLRETURN set_autocommit(bool value);

Expand Down