[CHERRY-PICK] StandaloneMmPkg/Core: Return when processing malformed DEPEX - #1895
Merged
Michael Kubacki (makubacki) merged 1 commit intoSep 1, 2026
Conversation
Contributor
⏩ QEMU Validation SkippedThe PR was merged before validation completed. This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1895 +/- ##
================================================
Coverage ? 0.50%
================================================
Files ? 30
Lines ? 5582
Branches ? 31
================================================
Hits ? 28
Misses ? 5554
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Aaron (apop5)
approved these changes
Aug 31, 2026
Vineel Kovvuri[MSFT] (vineelko)
approved these changes
Sep 1, 2026
Michael Kubacki (makubacki)
approved these changes
Sep 1, 2026
…DEPEX For a well-formed Dependency Expression, the code should never get here. The BEFORE and AFTER are processed prior to this routine's invocation. If the code flow arrives at this point, present code only called ASSERT(FALSE), causing release builds to fall through to the EFI_DEP_SOR case. Adding an explicit return FALSE after the assertion ensures correct error handling in release and debug build modes. This commit also addresses the fix for Coverity issue "MISSING BREAK" Cc: Sachin Ganesh <sachinganesh@ami.com> Signed-off-by: Gowtham M <gowthamm@ami.com> (cherry picked from commit 7e0b85e)
Michael Kubacki (makubacki)
force-pushed
the
CAT_Change_2
branch
from
September 1, 2026 18:48
a5015f6 to
3363596
Compare
Michael Kubacki (makubacki)
enabled auto-merge (rebase)
September 1, 2026 18:48
Michael Kubacki (makubacki)
merged commit Sep 1, 2026
12f8ff0
into
microsoft:release/202511
56 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For a well-formed Dependency Expression, the code should never get here. The BEFORE and AFTER are processed prior to this routine's invocation. If the code flow arrives at this point, present code only called ASSERT(FALSE),
causing release builds to fall through to the EFI_DEP_SOR case.
Adding an explicit return FALSE after the assertion ensures correct error handling in release and debug build modes.
This commit also addresses the fix for Coverity
issue "MISSING BREAK"
Cc: Sachin Ganesh sachinganesh@ami.com
(cherry picked from commit 7e0b85e)
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>