[release/202608] Update BaseTools ext dep to v2026080000.0.0-rc0 - #1901
Merged
Aaron (apop5) merged 13 commits intoSep 3, 2026
Merged
Conversation
Signed-off-by: Project Mu UEFI Bot <uefibot@microsoft.com>
Aaron (apop5)
approved these changes
Aug 31, 2026
Joey Vagedes (Javagedes)
approved these changes
Aug 31, 2026
Contributor
Author
❌ QEMU Validation FailedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/33696950572 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/202608 #1901 +/- ##
=================================================
Coverage ? 1.70%
=================================================
Files ? 1674
Lines ? 417191
Branches ? 0
=================================================
Hits ? 7121
Misses ? 410070
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Aaron (@apop5), can you please update the PR description to briefly explain why these extra commits are included in the ext dep update PR? |
Aaron (apop5)
force-pushed
the
sync-basetools/release/202608/v2026080000.0.0-rc0
branch
from
September 2, 2026 04:36
3ec2551 to
48cad2e
Compare
ManeagabilityPkg was misspelled, causing pipelines to fail. Update the mu_devops container images to satisfy IA32 host based unit test requirements. Squash with Enable CI on rebase
IA32 CI build fails due to _allmul being emitted. Update two places to use BaseLib's functions instead of relying upon the compiler. Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
NOOPT VS2022 IA32 builds emit references to the unsupported __allmul compiler intrinsic when a UINT64 index is used to access the ADMA descriptor array. Calculate each descriptor address with MultU64x32() and access its fields through a typed pointer. Add the explicit BaseLib dependency required by the helper. This allows EmmcBlockIoPei to link in NOOPT VS2022 IA32 builds. Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
NOOPT VS2022 IA32 builds emit references to the unsupported __allmul compiler intrinsic when a UINT64 index is used to calculate PRP entry addresses. Use MultU64x32() for the PRP entry offsets. Add the BaseLib header and library class dependency required by the helper. This allows NvmExpressPei to link in NOOPT VS2022 IA32 builds. Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
NOOPT VS2022 IA32 builds emit references to the unsupported __allmul compiler intrinsic when page counts and bitmap indices are converted to byte offsets. Use LShiftU64() for page-size calculations and the bitmap mask shift instead of relying on native UINT64 arithmetic. This allows CoreDxe to link in NOOPT VS2022 IA32 builds. Squash with MdeModulePkg: Enable MemoryProtectionSupport Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
NOOPT VS2022 IA32 builds emit references to the unsupported __allmul compiler intrinsic when a UINT64 index is used to calculate PRP entry addresses. Use MultU64x32() for the PRP list and entry offsets, and access each entry through a typed pointer. This allows NvmExpressDxe to link in NOOPT VS2022 IA32 builds. Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
NOOPT VS2022 IA32 builds emit references to the unsupported __allmul compiler intrinsic when a UINT64 index is used to access the ADMA descriptor arrays. Calculate each descriptor address with MultU64x32() and access its fields through a typed pointer for all supported ADMA modes. This allows SdMmcPciHcDxe to link in NOOPT VS2022 IA32 builds. Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
This reverts commit 82ae1da.
…ting DumpUicCmdExecResult & DumpQueryResponseResult are called to dump the result of UIC commands after a failure. Depending on the nature of the failure, not all information may have been properly initialized. This is already handled in callers with existing retry logic, but the assert in the dump command can cause a crash in debug builds for due to hardware race conditions on first attempt. Signed-off-by: Chris Fernald <chfernal@microsoft.com> (cherry picked from commit 2e53034f67fba2209468fdde33b6d0e0c24f767f)
Aaron (apop5)
force-pushed
the
sync-basetools/release/202608/v2026080000.0.0-rc0
branch
from
September 2, 2026 20:58
4966ac5 to
42761a0
Compare
Unit test assertion and mocking macros intentionally convert between pointers and 64-bit integer values. GCC IA32 host builds report these conversions with messages such as: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] These errors are produced by uses of UnitTestLib.h and Cmocka macros, as well as unit test code retrieving pointer values from mocks. Add -Wno-error for both warnings to the shared GCC IA32 host unit test build options. This retains the warnings while allowing all affected host unit tests to build.
Michael Kubacki (makubacki)
approved these changes
Sep 3, 2026
Aaron (apop5)
deleted the
sync-basetools/release/202608/v2026080000.0.0-rc0
branch
September 3, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates mu_devops ubuntu container to 0e384ee to allow IA32 host based unit tests to build and run under GCC.
Fix misspelling of ManeagabilityPkg in pipeline files, which caused pipeline failures.
Fix multiple places where IA32 CI builds were emitting compiler intrinsic calls.
Revert 2 commits which are no longer necessary (artifact of rebase that was already fixed in upstream)
Revert 1 commit and Cherry-Pick EDK2 change instead