Handle container creation and policy more cleanly - #15
Merged
Conversation
Gudge (MGudgin)
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update contains three sets of fixes
Filesystem policy needs to allow for BFS to handle the root of the C: drive. But this policy cannot be container inherit, so the logic is currently hardwired into WXC.
The container process is currently created with handle inherit enabled. This change disables inheritance but explicitly passes the handles for stdin/out/err through process attributes.
Detection of shutdown by either caller or container is handled better. Wait on the termination of handles OR process termination, then ensure IO is cancelled and threads shutdown.