Docs + windows runner error updates + SDK version bump#463
Merged
Conversation
SDK platform detection: - Replace checkWindowsBuildVersion with isIsoSessionSupported (Insider Preview build 26300.8553+). - computeSupport on Windows now always marks supported with processcontainer default and conditionally appends windows_sandbox and isolation_session. Docs: - Add Platforms table to root README and sdk/README with a Minimum build column; root README now points to the SDK README as the supported integration surface. - Update troubleshooting wording from build/UBR specifics to pre-24H2; broaden Linux to also list Bubblewrap. Rust runner validation: - AppContainer and BaseContainer runners now reject filesystem.deniedPaths, network.allowedHosts, and network.blockedHosts with a clear 'not yet supported on Windows' error (AppContainer still permits deniedPaths when running in DACL mode). - Error strings live as shared pub(crate) const in script_runner.rs so both runners surface identical wording; doc-comment explains the AppContainer + ALL APPLICATION PACKAGES access model. - Both runners log a one-line warning when network.proxy is configured: WinHTTP-only proxying, with the AppContainer-specific UAC caveat preserved. Build pipeline: - Add wxc-host-prep.exe to the Windows signPattern in Rust.Build.Job.yml so it ships alongside the other Windows binaries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…xample, trim shared error doc - Platforms table: split Windows minimum-build cell across two lines using <br> for clarity. - platform.ts: drop redundant isoSessionSupportedCache (getPlatformSupport already memoizes). - README permissiveLearningMode example: add version/containerId/containment, replace bogus 'script' with process.commandLine, note debug-builds-only. - script_runner.rs: trim the shared error doc comment to just state what the constants are and why they're shared. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… defaults - Merge brings PR 455: 0.6.0-alpha promoted to stable, dev schema renamed to 0.7.0-dev, Linux default backend now bubblewrap, supported schema range extended through 0.7. - Bump src/Cargo.toml [workspace.package].version 0.3.0 -> 0.6.0 to match the stable schema. - Bump sdk/package.json 0.3.0 -> 0.6.0 (npm install regenerated sdk/package-lock.json). - Update README.md and sdk/README.md Platforms tables to reflect bubblewrap as the Linux default and schema 0.6.0-alpha for macOS. - Resolve sdk/README.md conflict, keeping our Minimum-build column. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Version bump: - src/Cargo.toml [workspace.package].version 0.3.0 -> 0.6.0 (matches stable schema). - sdk/package.json 0.3.0 -> 0.6.0; npm install regenerated sdk/package-lock.json. - scripts/check-version-sync.js passes. Tests: - appcontainer_runner: add 5 validate_runner tests covering deniedPaths in BFS (reject) vs DACL (accept) modes, allowedHosts/blockedHosts rejection, and the all-empty-policy case. - base_container_runner: add 4 validate_runner tests covering the same policy fields; the empty-policy case is guarded on hosts where the BaseContainer API isn't present. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…vailability gate - Extract a WindowsBuildQuery seam in platform.ts so the IsolationSession version check (build 26300.8553+) can be exercised deterministically without depending on the host's actual build. - Add 5 unit tests covering the gate: below threshold, exactly at threshold, newer major, registry-unavailable, and the 'processcontainer is always the default on Windows now that the SDK build gate is removed' regression guard. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…AC warning Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
script_runner.rs is platform-agnostic; cfg-gating Windows-only constants under it was a layering smell. Move them into a new wxc_common::windows_policy_errors module declared under the existing cfg(target_os = windows) block in lib.rs, alongside the other Windows-only modules. No per-item cfg gates needed; both runners now use crate::windows_policy_errors::*. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…erShell - Drop the dedicated windows_policy_errors module; put the two pub(crate) const strings in error.rs (the obvious place readers look for error-related stuff) behind per-item cfg(target_os=windows) gates. - README ETW-tracing example now uses PowerShell instead of Python and sets policy.ui.allowWindows=true since PowerShell needs win32k at startup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… only The 0.4.0-alpha legacy AppContainer path natively honors blockedHosts (Windows Firewall) and deniedPaths (DACL on Tier 3 hosts), so the strict reject we surface for BaseContainer (0.5.0-alpha+) must not fire on 0.4 configs. Use is_base_container_version() to scope both runners checks. Also reword the error strings from "on Windows" to "on this Windows backend" so they accurately describe the BaseContainer-era scope. Added two legacy-schema tests (one per runner) confirming 0.4 configs with deniedPaths/allowedHosts/blockedHosts pass through validate_runner unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…DK 0.4 heads-up - Root README: drop the "supported integration surface" claim; just note the SDK exists and link to its README. - SDK README: replace the 0.4-specific firewall/proxy/elevation paragraph with a concise statement that host allow/block lists are not implemented on Windows; point at defaultNetworkPolicy / network.proxy as alternatives. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…bsolete test configs
The SDK README now states host allow/block lists are not implemented on Windows (period), so the runner-side schema gate that exempted 0.4.0-alpha was inconsistent with the docs. Remove the gate from both AppContainer and BaseContainer runners; restore the original on-Windows error wording.
Test configs whose entire purpose was exercising the now-rejected fields are deleted:
- tests/examples/02_filesystem_access.json (deniedPaths)
- tests/examples/03_network_restricted.json (allowedHosts)
- tests/examples/04_combined_restrictions.json (both)
- tests/configs/network_{both,capabilities,default,firewall}_test.json (allowedHosts variants)
tests/examples/11_localhost_proxy_processcontainer.json keeps its proxy assertions; the allowedHosts entry is dropped.
Drop the legacy-schema unit tests added in the previous commit; revert the request helpers to ExecutionRequest::default().
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… reject path The warning told users to enable BaseContainer (via --experimental or schema 0.5+) to make deniedPaths work, which is the exact configuration that now errors out. Removing it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…mplemented) Per Alex: keep these as forward-looking regression coverage. They currently fail with our not-yet-supported errors; future work will make them pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sdk/tests/integration/package-lock.json regenerated; mxc-sdk link now resolves at 0.6.0. Skipping playground for now: its package.json has a broken file: path (file:../sdk dating back to the PR #459 reorg that moved playground under tests/). Fixing it correctly resolves the SDK link but rewrites ~1k lines of phantom transitive deps the old broken path was pinning. Leaving that for a focused PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates MXC’s Windows support/docs posture, tightens Windows runner validation for unsupported policy fields, and bumps Rust/SDK package versions to 0.6.0.
Changes:
- Removes SDK-side Windows build support gating while separately gating
isolation_session. - Adds Windows runner validation/errors for unsupported
deniedPathsand host allow/block lists, plus proxy warnings. - Updates docs, examples, package versions, locks, and Windows signing artifact patterns.
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Updates platform/build docs and sample config. |
sdk/README.md |
Updates platform matrix, Windows network policy note, and troubleshooting. |
sdk/src/platform.ts |
Refactors Windows build detection and IsolationSession availability gate. |
sdk/tests/unit/platform.test.ts |
Adds unit tests for the new IsolationSession build gate. |
src/wxc_common/src/error.rs |
Adds shared Windows unsupported-policy error strings. |
src/wxc_common/src/appcontainer_runner.rs |
Adds AppContainer validation and proxy warning behavior with tests. |
src/wxc_common/src/base_container_runner.rs |
Adds BaseContainer validation and proxy warning behavior with tests. |
src/wxc/src/main.rs |
Removes obsolete deniedPaths warning. |
tests/examples/11_localhost_proxy_processcontainer.json |
Removes unsupported host allow-list from proxy example. |
src/Cargo.toml |
Bumps Rust workspace version to 0.6.0. |
src/Cargo.lock |
Regenerates workspace crate versions. |
sdk/package.json |
Bumps SDK package version to 0.6.0. |
sdk/package-lock.json |
Regenerates SDK lockfile version metadata. |
sdk/tests/integration/package-lock.json |
Regenerates integration lockfile version metadata. |
.azure-pipelines/templates/Rust.Build.Job.yml |
Adds wxc-host-prep.exe to Windows signing/copy pattern. |
Files not reviewed (2)
- sdk/package-lock.json: Language not supported
- sdk/tests/integration/package-lock.json: Language not supported
…fix UI block in README example - error.rs + sdk/README: defaultNetworkPolicy -> network.defaultPolicy; deny -> block. - sdk/README troubleshooting: drop the pre-24H2 Windows clause now that computeSupport always reports isSupported on Windows. - README PowerShell example: top-level ui.disable=false (the actual wire field) instead of the bogus policy.ui.allowWindows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bbonaby
changed the title
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
baf0f5f baf0f5f simplified isIsoSessionSupported to `major > 26300` (UBR not verifiable outside Insider Preview). The "exactly 26300.8553 -> included" test still asserted the old `>= 8553` semantics and failed in CI. Updated the test set: 26300.x is now omitted (regardless of minor), 26400.x is included, plus the existing null and far-below cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… band) Per manager: drop the `major > 26300` fallback; require the specific Insider Preview build that introduced IsolationSession. Future major builds will be added explicitly when they ship support. Test set: 26300.8552 omitted, 26300.8553 included, 26300.9999 included, 26400.x omitted (gate pinned), null omitted, plus the processcontainer-always regression guard. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kanismohammed
approved these changes
May 30, 2026
jsidewhite
reviewed
May 30, 2026
| #[cfg(target_os = "windows")] | ||
| pub(crate) const DENIED_PATHS_NOT_SUPPORTED_MSG: &str = | ||
| "filesystem.deniedPaths is not yet supported on Windows. Paths are denied by \ | ||
| default unless granted via readwritePaths or readonlyPaths. Remove deniedPaths, \ |
Member
There was a problem hiding this comment.
This is slightly misleading - technically it's true, but if there's ALL APPLICATION PACKAGES ace is on the file, then AppContainer can access it.
Collaborator
Author
There was a problem hiding this comment.
I can add that in if you want to make it more correct
Member
There was a problem hiding this comment.
No, let's just make a mental note for next week to update verbiage somewhere in the docs to make this clear.
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- EXPECTED_WINDOWS_BINARIES: add wxc-host-prep.exe so the "no unexpected binaries" check accepts the binary this PR added to the Windows signPattern. Also auto-generates a "should include wxc-host-prep.exe" sub-test. - assertDryRunResult: drop the DryRunExpectation enum and the expectDryRunValidationPass wrapper. The previous processmodel.dll heuristic assumed BaseContainer was the only viable route on schema 0.5+, but the dispatcher always falls back to AppContainer+DACL via the default fallback.allowDaclMutation=true. Simplified to a 3-arg helper that only asserts the pass case; failures are real regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kanismohammed
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Round of docs + Windows runner cleanup, bundled into one PR so the docs, validator, error wording, and version bump all land coherently.
sdk/src/platform.ts): drop the oldcheckWindowsBuildVersiongate. Windows 24H2+ is now reported as supported withprocesscontainerdefault andisolation_sessionconditionally appended when the host build is ≥ 26300.8553 (Insider Preview gate). Added a_setWindowsBuildQuerytest seam and 5 unit tests covering the gate.@microsoft/mxc-sdknow points at the npm package page. The SDK0.4.0-alphafirewall paragraph is replaced with a concise "host allow/block lists are not implemented on Windows" note.validate_runnernow rejectfilesystem.deniedPaths,network.allowedHosts, andnetwork.blockedHostsunconditionally on Windows (AppContainer keeps its DACL-mode exception fordeniedPaths). Both runners also log a one-line warning whennetwork.proxyis set (WinHTTP-only proxying; AppContainer-side UAC caveat preserved). Shared error strings live inwxc_common::error.deniedPathswarning inwxc/main.rsthat contradicted the new reject path.0.3.0→0.6.0to match the new stable schema;.wxc-host-prep.exeto the WindowssignPatternin.azure-pipelines/templates/Rust.Build.Job.yml.🔗 References
None.
🔍 Validation
cargo test --workspace --libon x86_64-pc-windows-msvc — all green (454 inwxc_common, including 9 newvalidate_runnertests).cd sdk; npm run build && npm test— 174 total / 170 pass / 4 skipped / 0 fail.node scripts/check-version-sync.js→Version sync OK: 0.6.0.CurrentBuild/UBR).✅ Checklist
📋 Issue Type
Microsoft reviewers: PR builds don't auto-run (ADO policy). Comment
/azp runto start
MXC-PR-Build. See docs/pull-requests.md.