Skip to content

fix(host-prep): avoid recursive ACL propagation on drive roots #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xuli500177 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(host-prep): avoid recursive ACL propagation on drive roots #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions docs/host-prep.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,11 @@ What this **does not** grant:
- `FILE_READ_DATA` — irrelevant on a directory, but explicit.
- any write rights.

Because the ACEs are non-inheriting, descendant files and
subdirectories of `C:\` are unaffected.
Because the ACEs are non-inheriting and the write path explicitly
suppresses automatic inheritance propagation, descendant files and
subdirectories of `C:\` are unaffected. This also avoids normalizing
legacy or inheritance-inconsistent ACLs elsewhere on a data volume
when `--target` selects a non-system drive.

Re-running `prepare-system-drive` is idempotent: when our exact ACE
is already present, the scan-before-apply path detects the match and
Expand Down Expand Up @@ -253,10 +256,11 @@ that captures stdout/stderr itself.
runtime check still trips if a debug build (no manifest) is
launched without `Run as Administrator`.
- The DACL operations for `prepare-system-drive` /
`unprepare-system-drive` use the same
`GetNamedSecurityInfoW` → `SetEntriesInAclW` →
`SetNamedSecurityInfoW` sequence as
`wxc_common::filesystem_dacl`. Apply ACEs are *not* tracked by
`unprepare-system-drive` read and merge the root DACL using the
shared `wxc_common::filesystem_dacl` helpers, then write it with
`SetFileSecurityW`. Unlike `SetNamedSecurityInfoW`, this changes
only the named drive root and does not impose the current
inheritance model on descendants. Apply ACEs are *not* tracked by
`DaclManager` — the change is intentionally persistent across
process exit. The precise-revoke path scans the existing DACL
via `GetAce` to find ACEs matching our exact tuple, then issues
Expand Down
Loading