Align 0.7 adapter tests with backend constraints - #912
Merged
Gudge (MGudgin) merged 1 commit intoAug 14, 2026
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Gudge (MGudgin)
force-pushed
the
user/gudge/version_specific_config_parsers_phase4_2
branch
from
August 14, 2026 20:59
d4c1990 to
4c0221c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns 0.7 adapter test fixtures with backend containment constraints.
Changes:
- Splits empty-section fixtures by backend.
- Adds matching containment values and equivalence tests.
- Preserves nested ProcessContainer UI coverage.
Show a summary per file
| File | Description |
|---|---|
src/core/wxc_common/src/config_contract_adapters/v0_7.rs |
Updates 0.7 adapter fixtures and tests. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
This PR aligns the 0.7 adapter tests with the published backend-section constraints. Details * Split the mixed-backend empty request into generic, ProcessContainer, nested UI, and Seatbelt cases. * Add matching containment values to backend-section and AppContainer alias requests. * Preserve expected-wire and current-wire equivalence coverage for every empty-section shape. Tests * `cargo fmt --all -- --check` * `cargo check -p wxc_common --all-targets` * `cargo clippy -p wxc_common --all-targets -- -D warnings` * `cargo test -p wxc_common config_contract_adapters::v0_7` (28 tests passed) * `cargo test -p mxc_config_contract` (175 tests passed) * `git diff --check` Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Gudge (MGudgin)
force-pushed
the
user/gudge/version_specific_config_parsers_phase4_2
branch
from
August 14, 2026 21:23
4c0221c to
937e9c0
Compare
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
src/core/wxc_common/src/config_contract_adapters/v0_7.rs:626
- This fixes the Seatbelt enum fixture, but
request_with_process_container_ui_isolationat lines 612–620 still emitsprocessContainerwithout"containment": "processcontainer". That helper feeds both mapping and wire-equivalence tests, so the PR still leaves one 0.7 backend-section fixture violating the published matching-containment constraint.
"containment": "seatbelt",
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Soham Das (SohamDas2021)
approved these changes
Aug 14, 2026
Gudge (MGudgin)
deleted the
user/gudge/version_specific_config_parsers_phase4_2
branch
August 14, 2026 21:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the
0.7.0-alphaadapter tests with the published backend-section constraints.Details
Tests
cargo fmt --all -- --checkcargo check -p wxc_common --all-targetscargo clippy -p wxc_common --all-targets -- -D warningscargo test -p wxc_common config_contract_adapters::v0_7(28 tests passed)cargo test -p mxc_config_contract(175 tests passed)git diff --checkMicrosoft Reviewers: Open in CodeFlow