Merged
Conversation
jasongin
approved these changes
Jan 2, 2024
Member
jasongin
left a comment
There was a problem hiding this comment.
Overall this is a great improvement to the public API surface.
I just have some concerns about keeping conversion APIs for JSBigInt consistent with other types.
This was referenced Jan 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of the code refactoring that aims to simplify the code and to improve public API.
In this PR we remove the
JSNativeApi.csfile that mostly had extensions for theJSValuestruct.We still have
JSNativeApiclass in theJSError.csfile that we can remove in future PR.The key parts of this PR:
JSVativeApi.cscode is moved inside of theJSValuestruct.JSRuntimefunctions inJSValueis changed to minimize required verifications. New private functionsGetRuntimeandGetCurrentRuntimereturnnapi_envandnapi_valuein one call.JSNativeApiis changed to use the newJSValuefunctions.JSMarshallerchanges reflect the function changes fromJSNativeApistatic methods toJSValueinstance methods.In the next PRs we should improve the
JSValueAPI and API for other classes and structs.E.g. we can move some methods to JS type specific structs.