eng - avoid future that is immediately destroyed

index.ts

@@ -122,4 +122,3 @@ export function recognize({ modelPath, signal }: IKeywordRecognitionOptions): Pr
 }
 
 //#endregion
-

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vscode/node-speech",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Native bindings for Micrsooft Speech SDK",
   "repository": {
     "type": "git",

src/main.cc

@@ -99,11 +99,6 @@ class TranscriptionWorker : public Napi::AsyncProgressQueueWorker<TranscriptionW
       }
       auto recognizer = SpeechRecognizer::FromConfig(speechConfig, audioConfig);
 
-      auto phraseList = PhraseListGrammar::FromRecognizer(recognizer);
-      phraseList->AddPhrase("VS Code");
-      phraseList->AddPhrase("Visual Studio Code");
-      phraseList->AddPhrase("GitHub");
-
       // Callback: intermediate transcription results
       recognizer->Recognizing += [progress](const SpeechRecognitionEventArgs &e)
       {
@@ -431,12 +426,13 @@ class KeywordWorker : public Napi::AsyncProgressQueueWorker<KeywordWorkerCallbac
       };
 
       // Starts keyword recognition and wait for end & stopping
-      // We use std::thread because RecognizeOnceAsync is blocking
-      // even though it returns a future (this seems to be a bug in
-      // the SDK)
-      std::thread([&recognizer, &keywordRecognitionConfig]()
-                  { recognizer->RecognizeOnceAsync(keywordRecognitionConfig); })
-          .detach();
+      // We need to assign the future to a variable to avoid the
+      // future automatically getting destroyed, which would block
+      // the thread.
+      //
+      // Refs: https://github.com/Azure-Samples/cognitive-services-speech-sdk/issues/2229
+      // https://stackoverflow.com/questions/23455104/why-is-the-destructor-of-a-future-returned-from-stdasync-blocking
+      auto recognitionFuture = recognizer->RecognizeOnceAsync(keywordRecognitionConfig);
       this->waitingToStop.get();
       recognizer->StopRecognitionAsync().get();
     }