Skip to content

Build number generation v2#1571

Merged
paulvanbrenk merged 3 commits intofuturefrom
buildNumberGenerationV2
May 10, 2017
Merged

Build number generation v2#1571
paulvanbrenk merged 3 commits intofuturefrom
buildNumberGenerationV2

Conversation

@paulvanbrenk
Copy link
Copy Markdown
Contributor

Autogenerate file, assembly, and vsix versions from the build number.

@paulvanbrenk paulvanbrenk requested review from billti and minestarks May 10, 2017 00:55
@paulvanbrenk
Copy link
Copy Markdown
Contributor Author

The CI build is failing because it doesn't support VS 2017 yet.

<MajorVersion>1</MajorVersion>
<MinorVersion>4</MinorVersion>

<!-- This was reset for Dev15. It needs to eventually be reset to the current year for Dev16 -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't make as much sense here as it did in the original place you copied from. Here you can just set the year to 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still like to reset the year every so often to make sure the build numbers < int16.max

@paulvanbrenk paulvanbrenk merged commit 505c310 into future May 10, 2017
@paulvanbrenk paulvanbrenk deleted the buildNumberGenerationV2 branch May 10, 2017 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants