Test adapter reg key#1580
Merged
paulvanbrenk merged 2 commits intomicrosoft:futurefrom May 16, 2017
Merged
Conversation
Contributor
Author
|
@msft-cwells can you take a look |
msft-cwells
approved these changes
May 15, 2017
Contributor
msft-cwells
left a comment
msft-cwells
left a comment
There was a problem hiding this comment.
Looks fine. I can make the Queso code/setup set that reg key to disable NTVS test discovery.
| return (projectTypeGuids.IndexOf(projectGuid.ToString(), StringComparison.OrdinalIgnoreCase) >= 0); | ||
| } | ||
|
|
||
| public static bool IsTestAdapaterEnabled() |
Contributor
There was a problem hiding this comment.
I just made some changes in my VS PR to cache this value, since "IsTestProject" gets called many times during any single TestAdapter operation. We don't really need to hit the registry every time. You don't need to make a similar change in NTVS, up to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the regkey is set to something, disable the NTVS test adapter.