Check for null before dereference on RootPackage.HomePages

[mjbvz]

Defect
RootPackage.Homepage can return null to indicate that no root package
exists. This causes two potential null dereferences in DependencyNode.cs

Fix
This fix just adds a null check before accessing the enumerator on the
HomePages property.

[msftclas]

Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Matt Bierner). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

[mousetraps]

👍 - looks fine, though afaik Homepages is never null. Out of curiosity, was specific time when this was not the case, or did you just fix up as you came across it?

[mjbvz]

Debugging new project creation, I was hitting null dereferences in these two locations. I don't know specifically what step of project creation it was in at the time, but the RootPackage.Package property was null, so RootPackage.Homepages was returning null.

[mousetraps]

Oh, interesting... good catch!