Skip to content

Check for null before dereference on RootPackage.HomePages #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mousetraps merged 1 commit into from
Feb 25, 2016
Merged

Check for null before dereference on RootPackage.HomePages #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions Nodejs/Product/Nodejs/Project/DependencyNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,13 @@ internal override int QueryStatusOnNode(Guid cmdGroup, uint cmd, IntPtr pCmdText
if (cmdGroup == Guids.NodejsNpmCmdSet) {
switch (cmd) {
case PkgCmdId.cmdidNpmOpenModuleHomepage:
using (var enumerator = this.Package.Homepages.GetEnumerator()) {
if (enumerator.MoveNext() && !string.IsNullOrEmpty(enumerator.Current)) {
result = QueryStatusResult.ENABLED | QueryStatusResult.SUPPORTED;
} else {
result = QueryStatusResult.SUPPORTED;
if (this.Package.Homepages != null) {
using (var enumerator = this.Package.Homepages.GetEnumerator()) {
if (enumerator.MoveNext() && !string.IsNullOrEmpty(enumerator.Current)) {
result = QueryStatusResult.ENABLED | QueryStatusResult.SUPPORTED;
} else {
result = QueryStatusResult.SUPPORTED;
}
}
}
return VSConstants.S_OK;
Expand Down Expand Up @@ -225,9 +227,11 @@ internal override int ExecCommandOnNode(Guid cmdGroup, uint cmd, uint nCmdexecop
if (cmdGroup == Guids.NodejsNpmCmdSet) {
switch (cmd) {
case PkgCmdId.cmdidNpmOpenModuleHomepage:
using (var enumerator = this.Package.Homepages.GetEnumerator()) {
if (enumerator.MoveNext() && !string.IsNullOrEmpty(enumerator.Current)) {
Process.Start(enumerator.Current);
if (this.Package.Homepages != null) {
using (var enumerator = this.Package.Homepages.GetEnumerator()) {
if (enumerator.MoveNext() && !string.IsNullOrEmpty(enumerator.Current)) {
Process.Start(enumerator.Current);
}
}
}
return VSConstants.S_OK;
Expand Down