Skip to content

Remove ORT_ENABLE_RUNTIME_OPTIMIZATION_IN_MINIMAL_BUILD.#10778

Merged
edgchen1 merged 2 commits into
masterfrom
edgchen1/clean_up_enable_runtime_optimization_symbol
Mar 9, 2022
Merged

Remove ORT_ENABLE_RUNTIME_OPTIMIZATION_IN_MINIMAL_BUILD.#10778
edgchen1 merged 2 commits into
masterfrom
edgchen1/clean_up_enable_runtime_optimization_symbol

Conversation

@edgchen1

@edgchen1 edgchen1 commented Mar 5, 2022

Copy link
Copy Markdown
Contributor

Description
Remove ORT_ENABLE_RUNTIME_OPTIMIZATION_IN_MINIMAL_BUILD as it is now implied by ORT_EXTENDED_MINIMAL_BUILD.
Remove related CMake option.

Motivation and Context
Clean up code.


namespace graph_utils {

#if !defined(ORT_MINIMAL_BUILD) || defined(ORT_ENABLE_RUNTIME_OPTIMIZATION_IN_MINIMAL_BUILD)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved code so that less specific sections are first.
all builds -> !defined(ORT_MINIMAL_BUILD) || defined(ORT_EXTENDED_MINIMAL_BUILD) -> !defined(ORT_MINIMAL_BUILD)

@skottmckay skottmckay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edgchen1
edgchen1 merged commit c147c9d into master Mar 9, 2022
@edgchen1
edgchen1 deleted the edgchen1/clean_up_enable_runtime_optimization_symbol branch March 9, 2022 00:18
lavanyax pushed a commit to intel/onnxruntime that referenced this pull request Mar 29, 2022
…0778)

Remove ORT_ENABLE_RUNTIME_OPTIMIZATION_IN_MINIMAL_BUILD as it is now implied by ORT_EXTENDED_MINIMAL_BUILD.
Remove related CMake option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants