Fix gen_doc for training build#10980
Closed
pengwa wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Add @skottmckay since it introduced lots of training specific op definition update into "docs/ContribOperators.md" and "docs/OperatorKernels.md". To make sure there is no big concern. |
Contributor
Author
|
Looks our LambOptimizer schema is too long to load here. https://github.com/microsoft/onnxruntime/blob/647db5d40fa136f9c0e957c489fbc0fcdcc905ea/docs/ContribOperators.md Would like to heard your thoughts whether it is necessary to include training ops in those MD files. If needed anyway, we may truncate the content in our gen_doc python tools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix gen_doc for training build.
Notes: discussed with @mindest, there are few issues:
Since this issue impact training devs for limited scenarios (updating shared operator def & kernels), there are workarounds people feel acceptable: remove enable_training from building flag to update the MD files.
So let's revisit this issue once we need public training ops defs some day. Closing this PR.
When we do training build with "--gen_doc", we will get following failure.
Fix a build warning in fused_ops_frontend.cpp.
Motivation and Context