Add BuildError for --gen_doc and --enable_training#12630
Merged
Conversation
pengwa
approved these changes
Aug 17, 2022
thiagocrepaldi
added
documentation
baijumeswani
approved these changes
Aug 17, 2022
natke
removed
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when building ORT with both --gen_doc --enable_training, the document generation fails with missing
schemadefdefinition.That happens because only inference builds add python bindings for it. #10980 tried to address sch limitation, but it wasn't accepted
This PR adds a build validation error to warn the user about such limitation in the hope of saving debug time for an unsupported scenario