fuse Conv+Add+activation for CPU from different op-branch - #10987
Merged
Conversation
wejoncy
force-pushed
the
jicheng/fuse_elmentwise_op
branch
from
March 24, 2022 06:06
ff8fe25 to
bc3c13a
Compare
wejoncy
marked this pull request as ready for review
March 24, 2022 07:14
wejoncy
requested review from
Chen Fu (chenfucn),
snnn (snnn),
Yi-Hong Lyu (yihonglyu),
Yufeng Li (yufenglee) and
Zhang Lei (zhanghuanrong)
as code owners
March 24, 2022 07:14
Contributor
|
Chen Fu (@chenfucn) or Yufeng Li (@yufenglee) could you please review the changes to mlas code? |
wejoncy
force-pushed
the
jicheng/fuse_elmentwise_op
branch
from
March 30, 2022 12:10
2d8b9b0 to
5c633c6
Compare
added 2 commits
March 30, 2022 20:17
Yufeng Li (yufenglee)
approved these changes
Mar 31, 2022
Yufeng Li (yufenglee)
left a comment
Yufeng Li (yufenglee)
left a comment
Member
There was a problem hiding this comment.
Change in MLAS looks good to me.
Rinne (SanftMonster)
pushed a commit
to SanftMonster/onnxruntime
that referenced
this pull request
Apr 1, 2022
…10987) * Fuse op conv Add and activation from two branch * simplify code Co-authored-by: Jicheng Wen <jicwen@microsoft.com>
wejoncy
added a commit
that referenced
this pull request
Apr 1, 2022
* Fuse op conv Add and activation from two branch * simplify code Co-authored-by: Jicheng Wen <jicwen@microsoft.com>
wejoncy
added a commit
that referenced
this pull request
Apr 19, 2022
* Fuse op conv Add and activation from two branch * simplify code Co-authored-by: Jicheng Wen <jicwen@microsoft.com>
wejoncy
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Fuse op conv Add and activation from two branch * simplify code
Mike Seddon (seddonm1)
pushed a commit
to seddonm1/onnxruntime
that referenced
this pull request
May 15, 2022
…10987) * Fuse op conv Add and activation from two branch * simplify code Co-authored-by: Jicheng Wen <jicwen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
For CPU, we have to pay the cost of reschedule thread and re-read the data from memory for a even a element-wise op.
But once all of them fused into one Op, we don't need to pay for that. the benefit is strait forward for Resnet-like models.
Motivation and Context