Skip to content

Splitting quantize_tensor and quantize_input#12873

Merged
jchen351 merged 4 commits into
mainfrom
cjian/bugs_fix
Sep 7, 2022
Merged

Splitting quantize_tensor and quantize_input#12873
jchen351 merged 4 commits into
mainfrom
cjian/bugs_fix

Conversation

@jchen351

@jchen351 jchen351 commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Description: Describe your changes.
Splitting quantize_tensor and quantize_input into quantize_activation_tensor, quantize_weight_tensor, quantize_activation and quantize_weight
Motivation and Context
This will reduce the naming confusion

Comment thread onnxruntime/python/tools/quantization/onnx_quantizer.py Outdated
Comment thread onnxruntime/python/tools/quantization/onnx_quantizer.py
@chenfucn

chenfucn commented Sep 7, 2022

Copy link
Copy Markdown
Contributor
def is_input_a_weight(self, input_name):

Change this to is_input_an_initializer to be consistent with rest of the name change?


Refers to: onnxruntime/python/tools/quantization/onnx_quantizer.py:292 in 5ab6073. [](commit_id = 5ab6073, deletion_comment = False)

@chenfucn

chenfucn commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

It appears to me that we used to use 'initializer' as a synonym for 'weight', and this change is aim at changing that? It would be great if we can have explanation of this in comments.

@yufenglee yufenglee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jchen351
jchen351 merged commit acc8bdc into main Sep 7, 2022
@jchen351
jchen351 deleted the cjian/bugs_fix branch September 7, 2022 22:05
yihonglyu added a commit to acid-space-cowboy/onnxruntime that referenced this pull request Sep 9, 2022
PR microsoft#12873 is Splitting quantize_tensor and quantize_input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants