Skip to content

Misc transformer fixes - 3#14320

Merged
hariharans29 merged 10 commits into
mainfrom
hari/misc_transformer_fixes_3
Jan 20, 2023
Merged

Misc transformer fixes - 3#14320
hariharans29 merged 10 commits into
mainfrom
hari/misc_transformer_fixes_3

Conversation

@hariharans29

@hariharans29 hariharans29 commented Jan 17, 2023

Copy link
Copy Markdown
Member

Description

  1. Add options to disable vocab padding and init decoder subgraph usage in the convert_generation script. Currently, there are options to only enable it and the it is enabled by default (i.e.) a user cannot disable these features if needed

  2. Add test to ensure that the init_decoder is generated for GPT2 BeamSearch/GreedySearch. (Misc transformer fixes - 2 #14156 (comment))

Motivation and Context

Tie up some loose ends wrt to recently introduced optimizations

@hariharans29 hariharans29 changed the title WIP: Misc transformer fixes - 3 Misc transformer fixes - 3 Jan 19, 2023
@hariharans29 hariharans29 merged commit 2d8ee52 into main Jan 20, 2023
@hariharans29 hariharans29 deleted the hari/misc_transformer_fixes_3 branch January 20, 2023 21:57
@faxu faxu added the triage:approved Approved for cherrypicks for release label Jan 25, 2023
rui-ren pushed a commit that referenced this pull request Jan 27, 2023
rui-ren pushed a commit that referenced this pull request Jan 27, 2023
@faxu faxu removed the release:1.14 label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage:approved Approved for cherrypicks for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants