Disable optimizers for OpTester operator unit tests - #2237
Merged
Scott McKay (skottmckay) merged 2 commits intoOct 24, 2019
Merged
Disable optimizers for OpTester operator unit tests #2237Scott McKay (skottmckay) merged 2 commits into
Scott McKay (skottmckay) merged 2 commits into
Conversation
…t the operator directly rather than something that could have been modified by an optimizer. Disable TensorRT for Scan9 unit tests that fails when optimizers are enabled. Bug 525222 tracks that.
…ze and TRT doesn't cope with that op.
snnn (snnn)
approved these changes
Oct 24, 2019
Scott McKay (skottmckay)
deleted the
skottmckay/TurnOffOptimizersForOperatorUnitTests
branch
October 24, 2019 20:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
If optimizers run they can modify the node being tested, which would be an unexpected background change in the context of the operator unit tests. Disable the optimizers in OpTester.
Disable TensorRT for Scan9 unit tests that fails when optimizers are enabled. Bug 525222 tracks that.
Motivation and Context
Prevent unexpected changes happening in the background when unit testing operators.